Voice: Minor options menu fixes, fix decibel level freezing on muted speakers

assets/opensb/interface/opensb/voicechat/voicechat.lua

@@ -223,5 +223,6 @@ end
 
 function voiceToggle()
   set("enabled", not settings.enabled)
+  widget.playSound(fmt("/sfx/interface/voice_%s.ogg", settings.enabled and "on" or "off"), 0)
 	updateVoiceButton()
 end

assets/opensb/interface/optionsmenu/optionsmenu.config.patch

@@ -42,6 +42,7 @@
       "base" : "/interface/optionsmenu/tricontrolsbutton.png",
       "hover" : "/interface/optionsmenu/tricontrolsbuttonhover.png"
     },
-    "sfxValueLabel" : { "position" : [192, 142] } // this is 2px too low in vanilla lol
+    "sfxValueLabel" : { "position" : [192, 142] }, // this is 2px too low in vanilla lol
+    "musicSlider" : { "position" : [62, 126] }
   }
 }

source/frontend/StarVoice.cpp

@@ -362,14 +362,15 @@ void Voice::mix(int16_t* buffer, size_t frameCount, unsigned channels) {
 			VoiceAudioStream* audio = speaker->audioStream.get();
 			MutexLocker audioLock(audio->mutex);
 			if (speaker->playing && !audio->samples.empty()) {
-				if (!speaker->muted) {
-					mix = true;
 				for (size_t i = 0; i != samples; ++i)
 					speakerBuffer[i] = audio->take();
 
 				if (speaker != m_clientSpeaker)
 					speaker->decibelLevel = getAudioLoudness(speakerBuffer.data(), samples);
 
+				if (!speaker->muted) {
+					mix = true;
+
 					float volume = speaker->volume;
 					Array2F levels = speaker->channelVolumes;
 					for (size_t i = 0; i != samples; ++i)
@@ -396,10 +397,6 @@ void Voice::mix(int16_t* buffer, size_t frameCount, unsigned channels) {
 					}
 					//*/
 				}
-				else {
-					for (size_t i = 0; i != samples; ++i)
-						audio->take();
-				}
 				++it;
 			}
 			else {