Fix StringView::substr

source/core/StarStringView.cpp

@@ -338,27 +338,22 @@ bool StringView::equalsIgnoreCase(StringView s) const {
 }
 
 StringView StringView::substr(size_t position, size_t n) const {
-  auto len = size();
+  StringView ret;
-  if (position > len)
+  auto it_end = end();
-    throw OutOfRangeException(strf("out of range in StringView::substr({}, {})", position, n));
-
-  if (position == 0 && n >= len)
-    return *this;
-
-  String ret;
-  ret.reserve(std::min(n, len - position));
-
   auto it = begin();
-  std::advance(it, position);
+  for (size_t i = 0; i != position; ++i) {
-
+    if (++it == it_end)
-  for (size_t i = 0; i < n; ++i) {
+      throw OutOfRangeException(strf("out of range in StringView::substr({}, {})", position, n));
-    if (it == end())
-      break;
-    ret.append(*it);
-    ++it;
   }
 
-  return ret;
+  const char* start = &*it.base();
+
+  for (size_t i = 0; i != n; ++i) {
+    if (it++ == it_end)
+      return StringView(start, &*it.base() - start - 1);
+  }
+
+  return StringView(start, &*it.base() - start);
 }
 
 int StringView::compare(size_t selfOffset, size_t selfLen, StringView other,

source/core/StarUnicode.hpp

@@ -49,6 +49,10 @@ public:
 
   U8ToU32Iterator(BaseIterator b) : m_position(b), m_value(pending_read) {}
 
+  BaseIterator const& base() const {
+    return m_position;
+  }
+
   U32Type const& operator*() const {
     if (m_value == pending_read)
       extract_current();