osb/source/rendering/StarAssetTextureGroup.cpp
Kai Blaschke 431a9c00a5
Fixed a huge amount of Clang warnings
On Linux and macOS, using Clang to compile OpenStarbound produces about 400 MB worth of warnings during the build, making the compiler output unreadable and slowing the build down considerably.

99% of the warnings were unqualified uses of std::move and std::forward, which are now all properly qualified.

Fixed a few other minor warnings about non-virtual destructors and some uses of std::move preventing copy elision on temporary objects.

Most remaining warnings are now unused parameters.
2024-02-19 16:55:19 +01:00

86 lines
2.5 KiB
C++

#include "StarAssetTextureGroup.hpp"
#include "StarIterator.hpp"
#include "StarTime.hpp"
#include "StarRoot.hpp"
#include "StarAssets.hpp"
#include "StarImageMetadataDatabase.hpp"
namespace Star {
AssetTextureGroup::AssetTextureGroup(TextureGroupPtr textureGroup)
: m_textureGroup(std::move(textureGroup)) {
m_reloadTracker = make_shared<TrackerListener>();
Root::singleton().registerReloadListener(m_reloadTracker);
}
TexturePtr AssetTextureGroup::loadTexture(AssetPath const& imagePath) {
return loadTexture(imagePath, false);
}
TexturePtr AssetTextureGroup::tryTexture(AssetPath const& imagePath) {
return loadTexture(imagePath, true);
}
bool AssetTextureGroup::textureLoaded(AssetPath const& imagePath) const {
return m_textureMap.contains(imagePath);
}
void AssetTextureGroup::cleanup(int64_t textureTimeout) {
if (m_reloadTracker->pullTriggered()) {
m_textureMap.clear();
m_textureDeduplicationMap.clear();
} else {
int64_t time = Time::monotonicMilliseconds();
List<Texture const*> liveTextures;
filter(m_textureMap, [&](auto const& pair) {
if (time - pair.second.second < textureTimeout) {
liveTextures.append(pair.second.first.get());
return true;
}
return false;
});
liveTextures.sort();
eraseWhere(m_textureDeduplicationMap, [&](auto const& p) {
return !liveTextures.containsSorted(p.second.get());
});
}
}
TexturePtr AssetTextureGroup::loadTexture(AssetPath const& imagePath, bool tryTexture) {
if (auto p = m_textureMap.ptr(imagePath)) {
p->second = Time::monotonicMilliseconds();
return p->first;
}
auto assets = Root::singleton().assets();
ImageConstPtr image;
if (tryTexture)
image = assets->tryImage(imagePath);
else
image = assets->image(imagePath);
if (!image)
return {};
// Assets will return the same image ptr if two different asset paths point
// to the same underlying cached image. We should not make duplicate entries
// in the texture group for these, so we keep track of the image pointers
// returned to deduplicate them.
if (auto existingTexture = m_textureDeduplicationMap.value(image)) {
m_textureMap.add(imagePath, {existingTexture, Time::monotonicMilliseconds()});
return existingTexture;
} else {
auto texture = m_textureGroup->create(*image);
m_textureMap.add(imagePath, {texture, Time::monotonicMilliseconds()});
m_textureDeduplicationMap.add(image, texture);
return texture;
}
}
}